Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various maintenance tasks #582

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

akurtakov
Copy link
Member

No description provided.

@akurtakov akurtakov self-assigned this Dec 17, 2024
@akurtakov akurtakov changed the title Run verification build with Java 21 Various maintenance tasks Dec 17, 2024
Failed in
https://download.eclipse.org/eclipse/downloads/drops4/I20241217-0630/testresults/html/org.eclipse.equinox.p2.tests_ep435I-unit-linux-x86_64-java23_linux.gtk.x86_64_23.html
with really no message:
```
N/A

junit.framework.AssertionFailedError
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertFalse(Assert.java:39)
at junit.framework.Assert.assertFalse(Assert.java:47)
at junit.framework.TestCase.assertFalse(TestCase.java:216)
at org.eclipse.equinox.p2.tests.reconciler.dropins.SharedInstallTestsProfileSpoofEnabledConfigured.testUserDropinsStartup(SharedInstallTestsProfileSpoofEnabledConfigured.java:215)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at junit.framework.TestCase.runTest(TestCase.java:177)
at org.eclipse.equinox.p2.tests.AbstractProvisioningTest.runTest(AbstractProvisioningTest.java:968)
at junit.framework.TestCase.runBare(TestCase.java:142)
at junit.framework.TestResult$1.protect(TestResult.java:122)
at junit.framework.TestResult.runProtected(TestResult.java:142)
at junit.framework.TestResult.run(TestResult.java:125)
at junit.framework.TestCase.run(TestCase.java:130)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at org.eclipse.equinox.p2.tests.reconciler.dropins.ReconcilerTestSuite.run(ReconcilerTestSuite.java:87)
at junit.framework.TestSuite.runTest(TestSuite.java:241)
at junit.framework.TestSuite.run(TestSuite.java:236)
```

This PR removes insane assert messages and some other changes to make
code slightly easier on the eyes.
Copy link

github-actions bot commented Dec 17, 2024

Test Results

  375 files  ±0    375 suites  ±0   42m 35s ⏱️ - 3m 11s
1 904 tests ±0  1 901 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 712 runs  ±0  6 703 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit e6995cc. ± Comparison against base commit e257717.

♻️ This comment has been updated with latest results.

A bigger change will be needed to get rid of this suite methods thus
reverting it.
@akurtakov akurtakov merged commit bc38ead into eclipse-equinox:master Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant